From 3ed4b237e467563bc6b536a9eb3dbedfac1a6445 Mon Sep 17 00:00:00 2001
From: Kevin Jhang <kevin.jhang@ptlk.com.tw>
Date: Tue, 8 Feb 2022 10:19:34 +0800
Subject: [PATCH] fixed access violation error

---
 src/mms/iso_mms/server/mms_server.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/mms/iso_mms/server/mms_server.c b/src/mms/iso_mms/server/mms_server.c
index e292115e..89454563 100644
--- a/src/mms/iso_mms/server/mms_server.c
+++ b/src/mms/iso_mms/server/mms_server.c
@@ -555,10 +555,8 @@ exit_function:
     return retValue;
 }
 
-static char*
-mmsServer_getDataRef(MmsDomain* domain, char* itemId) {
-    char dataRefBuf[130];
-
+static void
+mmsServer_getDataRef(MmsDomain* domain, char* itemId, char* dataRefBuf) {
     const char* separator = strchr(itemId, '$');
 
     if (separator != NULL) {
@@ -576,8 +574,6 @@ mmsServer_getDataRef(MmsDomain* domain, char* itemId) {
     dataRefBuf[129] = 0;
 
     StringUtils_replace(dataRefBuf, '$', '.');
-
-    return dataRefBuf;
 }
 
 MmsDataAccessError
@@ -586,7 +582,9 @@ mmsServer_setValue(MmsServer self, MmsDomain* domain, char* itemId, MmsValue* va
 {
     MmsDataAccessError indication;
 
-    char* dataRefBuf = mmsServer_getDataRef(domain, itemId);
+    char dataRefBuf[130];
+
+    mmsServer_getDataRef(domain, itemId, dataRefBuf);
 
     if (self->writeHandler != NULL) {
         indication = self->writeHandler(self->writeHandlerParameter, domain,
@@ -616,7 +614,9 @@ mmsServer_setValueWithAlternateAccess(MmsServer self, MmsDomain* domain, char* i
 {
     MmsDataAccessError indication;
 
-    char* dataRefBuf = mmsServer_getDataRef(domain, itemId);
+    char dataRefBuf[130];
+        
+    mmsServer_getDataRef(domain, itemId, dataRefBuf);
 
     MmsValue* cachedArray;