From 04bc9fb0142e96d2bddce1fa44f750a5ed7bbb6a Mon Sep 17 00:00:00 2001 From: vbird <841952496@qq.com> Date: Thu, 2 Mar 2023 15:37:41 +0800 Subject: [PATCH] refactor(kafka_skin.h): remove producer_ check remove producer_ check --- include/spdlog/sinks/kafka_skin.h | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/include/spdlog/sinks/kafka_skin.h b/include/spdlog/sinks/kafka_skin.h index 48ca1688..12d62286 100644 --- a/include/spdlog/sinks/kafka_skin.h +++ b/include/spdlog/sinks/kafka_skin.h @@ -30,9 +30,9 @@ struct kafka_sink_config std::string produce_topic; int32_t flush_timeout_ms = 1000; - kafka_sink_config(const std::string & addr, const std::string & topic, int flush_timeout_ms = 1000) - : server_addr(addr) - ,produce_topic(topic) + kafka_sink_config(std::string addr, std::string topic, int flush_timeout_ms = 1000) + : server_addr{std::move(addr)} + ,produce_topic{std::move(topic)} ,flush_timeout_ms(flush_timeout_ms) {} }; @@ -79,19 +79,13 @@ public: ~kafka_skin() { - if (producer_ != nullptr) - { - producer_->flush(config_.flush_timeout_ms); - } + producer_->flush(config_.flush_timeout_ms); } protected: void sink_it_(const details::log_msg &msg) override { - if (producer_ != nullptr) - { - producer_->produce(topic_.get(), 0, RdKafka::Producer::RK_MSG_COPY, (void *)msg.payload.data(), msg.payload.size(), NULL, NULL); - } + producer_->produce(topic_.get(), 0, RdKafka::Producer::RK_MSG_COPY, (void *)msg.payload.data(), msg.payload.size(), NULL, NULL); } void flush_() override @@ -110,7 +104,7 @@ private: using kafka_sink_mt = kafka_skin; using kafka_sink_st = kafka_skin; -} +} // namespace sinks template inline std::shared_ptr kafka_logger_mt(const std::string &logger_name, spdlog::sinks::kafka_sink_config config) @@ -136,4 +130,4 @@ inline std::shared_ptr kafka_logger_async_st(std::string logger_ return Factory::template create(logger_name, config); } -} \ No newline at end of file +} // namespace spdlog \ No newline at end of file