Remove inner try catch in SPDLOG_LOGGER_CATCH

The fmt::format call should not throw formatting the exception message and the source code location.
4 years ago · 0d10e21c2f
parent ed27592537
commit 0d10e21c2f
1 changed files with 1 additions and 8 deletions
--- a/include/spdlog/logger.h
+++ b/include/spdlog/logger.h
@ -32,16 +32,9 @@
        catch (const std::exception &ex)                                                                                                   \
        {                                                                                                                                  \
            if(location.filename)                                                                                                          \
-            {                                                                                                                              \
-                try                                                                                                                        \
            {                                                                                                                              \
                err_handler_(fmt::format("{} [{}({})]", ex.what(), location.filename, location.line));                                     \
            }                                                                                                                              \
-                catch (const std::exception &ex)                                                                                           \
-                {                                                                                                                          \
-                    err_handler_(ex.what());                                                                                               \
-                }                                                                                                                          \
-            }                                                                                                                              \
            else                                                                                                                           \
            {                                                                                                                              \
                err_handler_(ex.what());                                                                                                   \