_pattern was never set... but it was also never used. Intentional by @gabime, or a reflection of a refactor with some data member left behind?

8 years ago · 18a0455b91
parent 5c5080d304
commit 18a0455b91
1 changed files with 2 additions and 2 deletions
--- a/include/spdlog/details/pattern_formatter_impl.h
+++ b/include/spdlog/details/pattern_formatter_impl.h
@ -503,9 +503,9 @@ class full_formatter SPDLOG_FINAL:public flag_formatter
 // pattern_formatter inline impl
 ///////////////////////////////////////////////////////////////////////////////
 inline spdlog::pattern_formatter::pattern_formatter(const std::string& pattern, pattern_time ptime)
-: _time(ptime), _pattern(pattern)
+: _time(ptime)
 {
-    compile_pattern(_pattern, _time);
+    compile_pattern(pattern, _time);
 }

 inline void spdlog::pattern_formatter::compile_pattern(const std::string& pattern, pattern_time ptime)