From 24117d0c3687af53137eb015d871a3a3a50ce361 Mon Sep 17 00:00:00 2001 From: sunlong169 <71108420+sunlong169@users.noreply.github.com> Date: Sun, 17 Oct 2021 08:41:16 +0800 Subject: [PATCH] the abstract interfaces should be private other than protected The abstract interfaces of `class base_sink` should be private other than protected. These methods won't be invoked by any derived class. --- include/spdlog/sinks/base_sink.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/spdlog/sinks/base_sink.h b/include/spdlog/sinks/base_sink.h index 21c5545f..81827115 100644 --- a/include/spdlog/sinks/base_sink.h +++ b/include/spdlog/sinks/base_sink.h @@ -38,7 +38,8 @@ protected: // sink formatter std::unique_ptr formatter_; Mutex mutex_; - + +private: virtual void sink_it_(const details::log_msg &msg) = 0; virtual void flush_() = 0; virtual void set_pattern_(const std::string &pattern);