mirror of https://github.com/gabime/spdlog.git
Remove unnecessary and inconsistent "final" from color sinks (#3430)
The use of "final" differed between ansicolor_sink and wincolor_sink, resulting in the code inheriting from std{err,out}_color_sink classes, which are defined as one or the other on different platforms, being able to override most of the functions under non-Windows platforms, but not under Windows. This seems gratuitously inconsistent, so just remove all "final" keywords from both classes, especially because there doesn't seem any good reason to use it and the other sink classes don't use it (with the exception of base_sink, which is special). This also incidentally fixes using "final override" in most places but "override final" in wincolor_sink.h. Fixes #3429.pull/3433/head
parent
ad725d34cc
commit
287333ee00
Loading…
Reference in New Issue