Update CMakeLists.txt comment

pull/3267/head
Gabi Melman 9 months ago committed by GitHub
parent 94526fa8e8
commit 35b0417fbe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -274,9 +274,9 @@ if(MSVC)
target_compile_options(spdlog PRIVATE "/Zc:__cplusplus") target_compile_options(spdlog PRIVATE "/Zc:__cplusplus")
target_compile_options(spdlog_header_only INTERFACE "/Zc:__cplusplus") target_compile_options(spdlog_header_only INTERFACE "/Zc:__cplusplus")
if(SPDLOG_MSVC_UTF8) if(SPDLOG_MSVC_UTF8)
# fmt requires the /utf-8 flag with huilding with msvc. # fmt requires the /utf-8 flag when building with msvc.
# see https://github.com/fmtlib/fmt/pull/4159 on why the additional # see https://github.com/fmtlib/fmt/pull/4159 on why the additional
# "$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>" are needed # "$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>" checks are needed
target_compile_options(spdlog PUBLIC $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/utf-8>) target_compile_options(spdlog PUBLIC $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/utf-8>)
target_compile_options(spdlog_header_only INTERFACE $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/utf-8>) target_compile_options(spdlog_header_only INTERFACE $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/utf-8>)
endif() endif()

Loading…
Cancel
Save