From 3bc899b1f7050b297a3f0c4f742173c137d66316 Mon Sep 17 00:00:00 2001 From: chuancey Date: Mon, 3 Jul 2023 21:03:16 +0800 Subject: [PATCH] classes declared as final should not define protected fields --- include/spdlog/async_logger.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/spdlog/async_logger.h b/include/spdlog/async_logger.h index 91a93fcb..2e66f1e2 100644 --- a/include/spdlog/async_logger.h +++ b/include/spdlog/async_logger.h @@ -51,13 +51,12 @@ public: std::shared_ptr clone(std::string new_name) override; -protected: +private: void sink_it_(const details::log_msg &msg) override; void flush_() override; void backend_sink_it_(const details::log_msg &incoming_log_msg); void backend_flush_(); -private: std::weak_ptr thread_pool_; async_overflow_policy overflow_policy_; };