small fix to pattern_formatter ctor

8 years ago · 7709fc70eb
parent bce33698be
commit 7709fc70eb
2 changed files with 3 additions and 3 deletions
--- a/include/spdlog/details/pattern_formatter_impl.h
+++ b/include/spdlog/details/pattern_formatter_impl.h
@ -487,8 +487,8 @@ class full_formatter SPDLOG_FINAL:public flag_formatter
 ///////////////////////////////////////////////////////////////////////////////
 // pattern_formatter inline impl
 ///////////////////////////////////////////////////////////////////////////////
-inline spdlog::pattern_formatter::pattern_formatter(const std::string& pattern, pattern_time_type pattern_time, std::string eol)
-    : _eol(move(eol)), _pattern_time(pattern_time)
+inline spdlog::pattern_formatter::pattern_formatter(const std::string& pattern, pattern_time_type pattern_time, const std::string& eol)
+    : _eol(eol), _pattern_time(pattern_time)
 {
    compile_pattern(pattern);
 }
--- a/include/spdlog/formatter.h
+++ b/include/spdlog/formatter.h
@ -29,7 +29,7 @@ class pattern_formatter SPDLOG_FINAL : public formatter
 {

 public:
-    explicit pattern_formatter(const std::string& pattern, pattern_time_type pattern_time = pattern_time_type::local, const std::string eol = spdlog::details::os::default_eol);
+    explicit pattern_formatter(const std::string& pattern, pattern_time_type pattern_time = pattern_time_type::local, const std::string& eol = spdlog::details::os::default_eol);
    pattern_formatter(const pattern_formatter&) = delete;
    pattern_formatter& operator=(const pattern_formatter&) = delete;
    void format(details::log_msg& msg) override;