no chdir2

10 years ago · 7fb7259b3b
parent a0a0a5eb6d
commit 7fb7259b3b
2 changed files with 4 additions and 3 deletions
--- a/include/spdlog/details/file_helper.h
+++ b/include/spdlog/details/file_helper.h
@ -215,7 +215,8 @@ public:
            if(r)
            {
 #ifdef _WIN32
-                //not yet
+                if(os::get_lasterror() != ERROR_ALREADY_EXISTS)
+                    return r;
 #else
                if(os::get_lasterror() != EEXIST)
                    return r;
--- a/include/spdlog/details/os.h
+++ b/include/spdlog/details/os.h
@ -133,7 +133,7 @@ constexpr inline unsigned short eol_size()
 inline int get_lasterror()
 {
 #ifdef _WIN32
-    //not yet
+    return GetLastError();
 #else
    return errno;
 #endif
@ -142,7 +142,7 @@ inline int get_lasterror()
 inline bool _mkdir(const std::string& dirname)
 {
 #ifdef _WIN32
-    //not yet
+    return CreateDirectoryA(dirname.c_str(), NULL) == 0;
 #else
    return mkdir(dirname.c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
 #endif