Merge pull request #1105 from jktjkt/do-not-impose-extra-warnings

Do not impose -Wextra -Wconversion etc on library users
6 years ago · 80740f0e46
parent e0b4ec54bd c60f790793
commit 80740f0e46
1 changed files with 3 additions and 5 deletions
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@ -80,12 +80,10 @@ target_link_libraries(spdlog_header_only INTERFACE Threads::Threads)
 #---------------------------------------------------------------------------------------
 if(SPDLOG_MASTER_PROJECT)
    if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
-        target_compile_options( spdlog PUBLIC -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
-        target_compile_options( spdlog_header_only INTERFACE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
+        target_compile_options( spdlog PRIVATE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
    endif()
    if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
-        target_compile_options( spdlog PUBLIC /W3 /WX )
-        target_compile_options( spdlog_header_only INTERFACE /W3 /WX)
+        target_compile_options( spdlog PRIVATE /W3 /WX )
    endif()

    include(cmake/sanitizers.cmake)