minor code cleanup

include/spdlog/common.h

@@ -127,8 +127,8 @@ using level_hasher = std::hash<int>;
 //
 enum class async_overflow_policy
 {
-    block,          // Block until message can be enqueued
+    block,         // Block until message can be enqueued
-    overrun_oldest  // Discard oldest message in the queue if full when trying to add new item.
+    overrun_oldest // Discard oldest message in the queue if full when trying to add new item.
 };
 
 //

include/spdlog/details/pattern_formatter.h

@@ -329,23 +329,19 @@ public:
         int total_minutes = os::utc_minutes_offset(tm_time);
 #endif
         bool is_negative = total_minutes < 0;
-        char sign;
         if (is_negative)
         {
             total_minutes = -total_minutes;
-            sign = '-';
+            dest.push_back('-');
         }
         else
         {
-            sign = '+';
+            dest.push_back('+');
         }
 
-        int h = total_minutes / 60;
+        fmt_helper::pad2(total_minutes / 60, dest); //hours
-        int m = total_minutes % 60;
-        dest.push_back(sign);
-        fmt_helper::pad2(h, dest);
         dest.push_back(':');
-        fmt_helper::pad2(m, dest);
+        fmt_helper::pad2(total_minutes % 60, dest); //minutes
     }
 
 private:

include/spdlog/sinks/sink.h

@@ -19,17 +19,7 @@ public:
         : formatter_(std::unique_ptr<spdlog::formatter>(new pattern_formatter("%+")))
     {
     }
-    //
+
-    //    explicit sink(const std::string &formatter_pattern)
-    //        : formatter_(std::unique_ptr<spdlog::formatter>(new pattern_formatter(formatter_pattern)))
-    //    {
-    //    }
-    //
-    //    // sink with custom formatter
-    //    explicit sink(std::unique_ptr<spdlog::formatter> sink_formatter)
-    //        : formatter_(std::move(sink_formatter))
-    //    {
-    //    }
 
     virtual ~sink() = default;