Always build static fmtlib version and fix fpic

CMakeLists.txt

@@ -127,7 +127,7 @@ if(SPDLOG_TIDY)
     message(STATUS "Enabled clang-tidy")
 endif()
 
-if(SPDLOG_BUILD_PIC)
+if(SPDLOG_BUILD_PIC OR SPDLOG_BUILD_SHARED)
     set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 endif()
 

cmake/fmtlib.cmake

@@ -1,4 +1,9 @@
 include(FetchContent)
+
+# Always build static fmtlib version
+set(BUILD_SHARED_LIBS_ORIG "${BUILD_SHARED_LIBS}")
+set(BUILD_SHARED_LIBS OFF CACHE BOOL "Disable BUILD_SHARED_LIBS for fmtlib" FORCE)
+
 Set(FETCHCONTENT_QUIET FALSE)
 FetchContent_Declare(
         fmt
@@ -10,7 +15,10 @@ FetchContent_Declare(
 FetchContent_GetProperties(fmt)
 if(NOT fmt_POPULATED)
     FetchContent_Populate(fmt)
-    # we do not require os features of fmt
+    # We do not require os features of fmt
     set(FMT_OS OFF CACHE BOOL "Disable FMT_OS" FORCE)
     add_subdirectory(${fmt_SOURCE_DIR} ${fmt_BINARY_DIR})
 endif ()
+
+# Restore BUILD_SHARED_LIBS
+set(BUILD_SHARED_LIBS "${BUILD_SHARED_LIBS_ORIG}" CACHE BOOL "Restore BUILD_SHARED_LIBS" FORCE)