From e5960580cfd2618369a9816f4544ae638063e432 Mon Sep 17 00:00:00 2001
From: Jonathan Vannier <vannier.jonathan@gmail.com>
Date: Mon, 25 Sep 2023 15:58:58 +0200
Subject: [PATCH] Replace std::list by std::vector

---
 include/spdlog/details/registry.h | 2 +-
 tests/test_registry.cpp           | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/spdlog/details/registry.h b/include/spdlog/details/registry.h
index 44e8738f..0aee3edc 100644
--- a/include/spdlog/details/registry.h
+++ b/include/spdlog/details/registry.h
@@ -116,7 +116,7 @@ private:
     std::shared_ptr<logger> default_logger_;
     bool automatic_registration_ = true;
     size_t backtrace_n_messages_ = 0;
-    std::list<std::function<void(const std::shared_ptr<logger>&)>> on_registration_callbacks_;
+    std::vector<std::function<void(const std::shared_ptr<logger>&)>> on_registration_callbacks_;
 };
 
 }  // namespace details
diff --git a/tests/test_registry.cpp b/tests/test_registry.cpp
index 9d081ba7..a9ff241e 100644
--- a/tests/test_registry.cpp
+++ b/tests/test_registry.cpp
@@ -112,7 +112,7 @@ TEST_CASE("disable automatic registration", "[registry]") {
 }
 
 TEST_CASE("add_on_registration_callback", "[registry]") {
-    std::list<std::string> registered_logger_names;
+    std::vector<std::string> registered_logger_names;
     auto on_registration_callback = [&](const std::shared_ptr<spdlog::logger>& logger)
     {
         registered_logger_names.push_back(logger->name());
@@ -132,7 +132,7 @@ TEST_CASE("add_on_registration_callback", "[registry]") {
     spdlog::register_logger(non_captured_registration_logger2);
 
     // Check that only the automatically registered logged and the manually registered logger were captured
-    REQUIRE(registered_logger_names == std::list<std::string>({"captured_registration_logger1", "captured_registration_logger2"}));
+    REQUIRE(registered_logger_names == std::vector<std::string>({"captured_registration_logger1", "captured_registration_logger2"}));
 
     spdlog::set_level(spdlog::level::info);
     spdlog::set_automatic_registration(true);