Replace std::list by std::vector

pull/2883/head
Jonathan Vannier 2 years ago
parent a8c56c2c7d
commit e5960580cf

@ -116,7 +116,7 @@ private:
std::shared_ptr<logger> default_logger_; std::shared_ptr<logger> default_logger_;
bool automatic_registration_ = true; bool automatic_registration_ = true;
size_t backtrace_n_messages_ = 0; size_t backtrace_n_messages_ = 0;
std::list<std::function<void(const std::shared_ptr<logger>&)>> on_registration_callbacks_; std::vector<std::function<void(const std::shared_ptr<logger>&)>> on_registration_callbacks_;
}; };
} // namespace details } // namespace details

@ -112,7 +112,7 @@ TEST_CASE("disable automatic registration", "[registry]") {
} }
TEST_CASE("add_on_registration_callback", "[registry]") { TEST_CASE("add_on_registration_callback", "[registry]") {
std::list<std::string> registered_logger_names; std::vector<std::string> registered_logger_names;
auto on_registration_callback = [&](const std::shared_ptr<spdlog::logger>& logger) auto on_registration_callback = [&](const std::shared_ptr<spdlog::logger>& logger)
{ {
registered_logger_names.push_back(logger->name()); registered_logger_names.push_back(logger->name());
@ -132,7 +132,7 @@ TEST_CASE("add_on_registration_callback", "[registry]") {
spdlog::register_logger(non_captured_registration_logger2); spdlog::register_logger(non_captured_registration_logger2);
// Check that only the automatically registered logged and the manually registered logger were captured // Check that only the automatically registered logged and the manually registered logger were captured
REQUIRE(registered_logger_names == std::list<std::string>({"captured_registration_logger1", "captured_registration_logger2"})); REQUIRE(registered_logger_names == std::vector<std::string>({"captured_registration_logger1", "captured_registration_logger2"}));
spdlog::set_level(spdlog::level::info); spdlog::set_level(spdlog::level::info);
spdlog::set_automatic_registration(true); spdlog::set_automatic_registration(true);

Loading…
Cancel
Save