From e842aa18f53ae1d7a8414882e3cd30881f71e3d7 Mon Sep 17 00:00:00 2001 From: Antoine Hoarau <703240+ahoarau@users.noreply.github.com> Date: Sat, 30 Nov 2024 11:49:13 +0100 Subject: [PATCH] Add missing xchat.h header for fmt > 11.0.2 using fmt main branch, after the 11.0.2 release, `fmt::basic_format_string` is defined in `xchar.h`. Otherwise compile error: ``` spdlog/common.h:369:49: error: no template named 'basic_format_string' in namespace 'fmt'; did you mean 'std::basic_format_string'? [build] 369 | inline fmt::basic_string_view to_string_view(fmt::basic_format_string fmt) { [build] | ^~~~~ [build] /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/format:128:12: note: 'std::basic_format_string' declared here [build] 128 | struct basic_format_string [build] | ^ [build] 1 error generated. ``` --- include/spdlog/fmt/fmt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/spdlog/fmt/fmt.h b/include/spdlog/fmt/fmt.h index 7fa6b093..2f09c15e 100644 --- a/include/spdlog/fmt/fmt.h +++ b/include/spdlog/fmt/fmt.h @@ -27,4 +27,5 @@ #else // SPDLOG_FMT_EXTERNAL is defined - use external fmtlib #include #include + #include #endif