diff --git a/example/example.cpp b/example/example.cpp index 77770f45..8bf4ab6f 100644 --- a/example/example.cpp +++ b/example/example.cpp @@ -416,9 +416,6 @@ void attribute_example() { spdlog::push_context({{"llong", ll }}); spdlog::push_context({{"ullong", ull }}); - // chars shouldnt work? - // spdlog::push_context({{"char", 'a' }}); - // floats shouldnt work // spdlog::push_context({{"float", 1.0f }}); // spdlog::push_context({{"double", 1.0 }}); diff --git a/include/spdlog/details/log_attr.h b/include/spdlog/details/log_attr.h index d6fa70d1..09321333 100644 --- a/include/spdlog/details/log_attr.h +++ b/include/spdlog/details/log_attr.h @@ -17,6 +17,7 @@ struct is_string template struct is_number : public std::integral_constant::value + && !std::is_same::value // || std::is_floating_point::value > {};